Skip to content

feat: add activatable status indicator to toolbar v2 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
thomaswhyyou wants to merge 1 commit into
base: thomas-kno-11142-sdk-guide-toolbar-v2-poc-6
Choose a base branch
from
Draft

feat: add activatable status indicator to toolbar v2 #847

thomaswhyyou wants to merge 1 commit into from

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026

Description

** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **

Todos

** List any todo items necessary before merging, if any. Delete if none. **

  • Sample todo item 1
  • Sample todo item 2

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

@linear
Copy link

linear bot commented Feb 2, 2026

KNO-11142 [SDK] Guide Toolbar v2 poc

@vercel
Copy link

vercel bot commented Feb 2, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 4, 2026 10:21pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 4, 2026 10:21pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 4, 2026 10:21pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 4, 2026 10:21pm

Request Review

This was referenced Feb 2, 2026
Open
Open
Open
@thomaswhyyou Graphite App
Copy link
Contributor Author

thomaswhyyou commented Feb 2, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 2, 2026
Draft
Draft
@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 559d59c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 67f3bd1 to bedf313 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from 89d2bfa to a415e75 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from a415e75 to b5369e6 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from bedf313 to 07cd540 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 07cd540 to e2af205 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from b5369e6 to 0a38e96 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 2fa23b3 to 2e05d0f Compare February 4, 2026 19:42
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from fc48d53 to e98e6cd Compare February 4, 2026 19:42
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from e98e6cd to ebd2339 Compare February 4, 2026 20:14
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 2e05d0f to ab7b831 Compare February 4, 2026 20:14
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from ab7b831 to 0c88894 Compare February 4, 2026 21:16
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from ebd2339 to 29661f1 Compare February 4, 2026 21:16
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 0c88894 to 559d59c Compare February 4, 2026 22:20
@thomaswhyyou thomaswhyyou changed the title add activatable status indicator feat: add activatable status indicator to toolbar v2 Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 21.27660% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.13%. Comparing base (3a56f71) to head (559d59c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 10.00% 18 Missing ⚠️
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 9.09% 10 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 0.00% 7 Missing ⚠️
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@                               Coverage Diff                               @@
##           thomas-kno-11142-sdk-guide-toolbar-v2-poc-6     #847      +/-   ##
===============================================================================
- Coverage                                        66.35%   66.13%   -0.22%     
===============================================================================
  Files                                              203      203              
  Lines                                             8429     8469      +40     
  Branches                                          1075     1076       +1     
===============================================================================
+ Hits                                              5593     5601       +8     
- Misses                                            2811     2843      +32     
  Partials                                            25       25
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 88.92% <100.00%> (+0.07%) ⬆️
packages/client/src/clients/guide/index.ts 100.00% <100.00%> (ø)
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 13.63% <0.00%> (-1.37%) ⬇️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 12.50% <0.00%> (-0.84%) ⬇️
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 9.57% <9.09%> (+1.33%) ⬆️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 10.10% <10.00%> (-2.10%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thomaswhyyou